This repository has been archived by the owner on May 29, 2019. It is now read-only.
refactor: Update deprecated chunk.modules functions
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/webpack3 #553 +/- ##
====================================================
+ Coverage 87.37% 87.74% +0.37%
====================================================
Files 7 7
Lines 301 302 +1
Branches 68 68
====================================================
+ Hits 263 265 +2
+ Misses 36 35 -1
Partials 2 2
Continue to review full report at Codecov.
|
|
Is there a date for this merge? I really need this |
|
@CGastrell - See my comment in the associated issue. |
|
Thank you, I really appreciate all the effort (and taking the time to reply). |
* corrected order for chunk.modules loop * added regression test for #548 * upgraded to latest webpack version 3.1.0 which includes needed Chunk.sortModules method * applied change to new location of index.js
joshwiens
changed the title
chunk.modules functions
joshwiens
added
pr_action: Review
type: Refactor
and removed
status: Pending
type: Bug
labels
BREAKING CHANGE: Updates to `Chunk.mapModules | forEachModule | getNumberOfModules`. This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764
joshwiens
force-pushed
the
d3viant0ne-FixCssOrder
branch
from
28e3360 to
1ec14f2
Compare
TheLarkInn
approved these changes
Jul 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces remaining usage of the deprecated
chunk.modulesfunctionsrefactor: Replace usage of chunk.modules
BREAKING CHANGE: Updates to
Chunk.mapModules | forEachModule | getNumberOfModules. This release is not backwards compatible withWebpack 2.xdue to breaking changes in Use a Set to store modules in a chunk webpack/webpack#4764Closes #548